Implement unused mut lint #4290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasly-ba
force-pushed
the
unused-mut
branch
6 times, most recently
from
fac95ea to
85f2a83
Compare
lucasly-ba
force-pushed
the
unused-mut
branch
3 times, most recently
from
758101a to
79876a5
Compare
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::UnusedChecker): Add warning for identifier pattern and field ident pattern in struct (UnusedChecker::visit): Add methods. * checks/lints/unused/rust-unused-checker.h: Same here. * checks/lints/unused/rust-unused-collector.cc (UnusedCollector::UnusedCollector): Collect unused mut variables (UnusedCollector::visit): Add methods. * checks/lints/unused/rust-unused-collector.h: Same here. * checks/lints/unused/rust-unused-context.cc (UnusedContext::remove_assign): Add methods for unused mut set. (UnusedContext::add_mut): Same here. (UnusedContext::remove_mut): Same here. (UnusedContext::is_mut_used): Same here. * checks/lints/unused/rust-unused-context.h: Same here. gcc/testsuite/ChangeLog: * rust/compile/unused-mut-identifier_0.rs: New test. * rust/compile/unused-mut-struct-field_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
lucasly-ba
force-pushed
the
unused-mut
branch
from
79876a5 to
537db96
Compare
P-E-P
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements unused mut lint, it uses the hir default visitor and visit IdentifierPattern and StructPatternFieldIdent, to add to a map of mutable vars in the lint unused context.
Requires #4285